Optimize networking (demo of concept) #1482
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a demo of concept, use code to discuss the concept.
When we have content need to be written to TCP buffer, instead of
We can first try 3, if all the content get copied to TCP buffer, then we save at least 2 system calls. If not, follow the original path.
Benchmark shows, even under heavy load of redis-benchmark, the latter happens rarely. So, most of the time, we can save two system call(two
epoll_ctl
on linux, which is O(n)), and less latency, since we do not need to wait until the next round,aeProcessEvents
get called.Only commands handing modified, we may need to modify replication logic too.
With this patch,
/src/redis-benchmark -t get -n 500000
can get 2%-3% faster.You can see from a profile without the patch,
epoll_ctl
cost ~8% of the CPU time.