bugfix: errno might change before logging #2666
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fclose(fp); | ||
| redisLog(REDIS_WARNING,"Write error writing append only file on disk: %s", strerror(errno_saved)); |
There was a problem hiding this comment.
how about moving redisLog line before fclose. it will remove using errno_saved
Signed-off-by: Yongyue Sun <abioy.sun@gmail.com>
antirez
added a commit
that referenced
this pull request
Jul 17, 2015
bugfix: errno might change before logging
|
Good catch, thanks! |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Aug 29, 2016
bugfix: errno might change before logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: errno might change before logging
Signed-off-by: Yongyue Sun abioy.sun@gmail.com