Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow writable command even aof_last_write_status == C_ERR #3206

Closed

Conversation

charsyam
Copy link
Contributor

@charsyam charsyam commented May 8, 2016

If someone set config set stop-writes-on-bgsave-error no,
then even though creating RDB fails, Redis allow Writable commands.

but currently, if aof_last_write_status is C_ERR, Redis always prohibits writable commands.

so. I think we should support redis can allow writable commands by admin.

so I think It is better that allow writable command when stop-writes-on-bgsave-error is no,
event though aof_last_write_status is C_ERR.

@yoav-steinberg
Copy link
Contributor

This code has since been refactored (401fe7fb948f6071d5f804fc3c1fbac77286dd5) and it seems to me the logic remains that if AOF is enabled and there's an error we don't allow write commands (regardless of RDB settings).
I'm not sure I understand the original intention behind this fix and having stop-writes-on-bgsave-error determine how to behave on an AOF write error seems confusing to me.
Suggest closing.

@yoav-steinberg yoav-steinberg added the state:to-be-closed requesting the core team to close the issue label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:to-be-closed requesting the core team to close the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants