Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mismatch argument and return wrong value of clusterDelNodeSlots #4128

Merged
merged 2 commits into from Jul 24, 2017
Merged

fix mismatch argument and return wrong value of clusterDelNodeSlots #4128

merged 2 commits into from Jul 24, 2017

Conversation

leonchen83
Copy link
Contributor

No description provided.

@itamarhaber
Copy link
Member

@leonchen83 good to see you dude, looks like a good fix imo

@badboy badboy marked this as a duplicate of #4129 Jul 18, 2017
@leonchen83
Copy link
Contributor Author

@itamarhaber
hi
have plan to upgrade rejson from RDB_TYPE_MODULE to RDB_TYPE_MODULE_2?

@itamarhaber
Copy link
Member

Yes, but this isn't the place to discuss it ;)

Also, rereading your fix here, looks like you'll print NULL in the error? Not sure that's good actually.

@leonchen83
Copy link
Contributor Author

leonchen83 commented Jul 18, 2017

@itamarhaber
same as line 4185. and according to condition !strcasecmp(c->argv[3]->ptr,"importing") && c->argc == 5
I think it should't be NULL.

@leonchen83
Copy link
Contributor Author

wdut, @itamarhaber ,@antirez

@leonchen83 leonchen83 changed the title fix mismatch argument fix mismatch argument and return wrong value of clusterDelNodeSlots Jul 20, 2017
@antirez
Copy link
Contributor

antirez commented Jul 24, 2017

Thanks @leonchen83, the return value is actually never used, so I guess this is just a theoretical fix right (which is totally fine, we may use the return value in the future). @itamarhaber not sure about the NULL problem, we use the argument printed immediately before in clusterLookupNode(c->argv[4]->ptr).

@antirez antirez merged commit d956537 into redis:unstable Jul 24, 2017
@antirez
Copy link
Contributor

antirez commented Jul 24, 2017

Both reviewed and merged. Thanks!

JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Aug 20, 2017
fix mismatch argument and return wrong value of clusterDelNodeSlots
pulllock pushed a commit to pulllock/redis that referenced this pull request Jun 28, 2023
fix mismatch argument and return wrong value of clusterDelNodeSlots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants