-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example os import usage for Swift 5/4 #283
Comments
If you’re building with 10.2, there’s little point to using this dependency anymore :) |
It should work just as before. Can you share what you're doing and what error you're seeing? |
@NachoSoto can you clarify? If I'm still supporting iOS 11, or still have dependencies that build for Swift 4.2? Do I need this dependency? Sorry if I'm not completely up to speed on all things upgrade, just giving it a shot to see what breaks. |
|
@NachoSoto Ok, so I think the issue there is a namespace one, and particularly with Apollo. Let me share the full imports. Apollo defines it's own Now for me to remove
Of course other options are, make a PR against Apollo, but we have other issues there that complicate that route. Does this outline sound like the right approach? Or from what I've shared, should importing |
Oh, in Swift 5 mode, this repo doesn't define
|
Hmm, ok, it looks like I can't get around doing the targeted import on Apollo then. thanks for the help! |
Just following up, targeted import on Apollo and removal of import of Result works. |
I might be doing something wrong, or missed some docs, but after upgrading to 10.2, the
Result
enum can't be found. I think I'm doing something wrong, and would like to just ask for some direction, and maybe a doc callout for proper import usage.The text was updated successfully, but these errors were encountered: