Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antrl4-<version>-sources.jar does not contain sources for runtime #1007

Closed
u3r opened this issue Sep 30, 2015 · 4 comments
Closed

antrl4-<version>-sources.jar does not contain sources for runtime #1007

u3r opened this issue Sep 30, 2015 · 4 comments

Comments

@u3r
Copy link

u3r commented Sep 30, 2015

The source artifact for

<groupId>org.antlr</groupId>    
<artifactId>antlr4</artifactId>

does not contain sources for the (contained) antr4-runtime.

Dependent on the order of the classpath (read maven-imports) this prevents eclipse from showing javadoc/source for the runtime-classes.

Please include all sources in the source artifact for antlr4.

@cowang
Copy link

cowang commented Aug 30, 2016

👍

In my case, I was trying to look at the source for AbstractParseTreeVisitor. My workaround was to get the source for antlr4-runtime artifact and substitute it for the antlr4 source in the Eclipse build path. If I ever need to look at the Antlr source for parsing or lexing, I'll be scratching my head for days trying to figure out what's wrong.

@sharwell
Copy link
Member

sharwell commented Dec 2, 2016

Interesting. @parrt I don't think this particular artifact is supposed to include the runtime classes either. It looks like the shaded jar got uploaded to Maven central instead of the original artifact. The shaded jar was only created for non-Maven based distributions.

@parrt
Copy link
Member

parrt commented Dec 11, 2016

@sharwell Hmm...how do i make both shaded (fat) jars and pure jar? seems like it only makes one jar. hang on. i think i found a way:

<shadedArtifactAttached>true</shadedArtifactAttached>
              <shadedClassifierName>jackofall</shadedClassifierName>

@parrt
Copy link
Member

parrt commented Dec 11, 2016

@cowang I think the source for runtime and the tool should be in separate jars and then the various IDEs will pull it in. antlr4 is the tool and antlr4-runtime are the mvn artifacts. The shaded jar should not have been deployed.

@parrt parrt added this to the 4.6 milestone Dec 11, 2016
@parrt parrt closed this as completed in 0dae635 Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants