Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated typescript types not correctly reflecting null option when Node is optional #4314

Open
ashley-taylor opened this issue Jun 15, 2023 · 0 comments

Comments

@ashley-taylor
Copy link

Given a gramma that has a parser rule like the following

atom
   : NUMBER
   | VARIABLE

This will generate the following AtomContext

export declare class AtomContext extends ParserRuleContext {
    constructor(parser?: CalculatorSyntaxParser, parent?: ParserRuleContext, invokingState?: number);
    NUMBER(): TerminalNode;
    VARIABLE(): TerminalNode;
    get ruleIndex(): number;
    enterRule(listener: CalculatorSyntaxListener): void;
    exitRule(listener: CalculatorSyntaxListener): void;
}

This does not reflect the optional nature of NUMBER and VARIABLE as those can be null
It should generate a context like the following instead

export declare class AtomContext extends ParserRuleContext {
    constructor(parser?: CalculatorSyntaxParser, parent?: ParserRuleContext, invokingState?: number);
    NUMBER(): TerminalNode | null;
    VARIABLE(): TerminalNode | null;
    get ruleIndex(): number;
    enterRule(listener: CalculatorSyntaxListener): void;
    exitRule(listener: CalculatorSyntaxListener): void;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant