Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi module name does not reflect Maven module name #980

Closed
FroMage opened this issue Aug 19, 2015 · 0 comments
Closed

OSGi module name does not reflect Maven module name #980

FroMage opened this issue Aug 19, 2015 · 0 comments
Labels
comp:build type:improvement
Milestone
4.6

Comments

@FroMage
Copy link

FroMage commented Aug 19, 2015

In https://github.com/antlr/antlr4/blob/master/runtime/Java/pom.xml#L42 the Bundle-SymbolicName OSGi attribute is org.antlr.antlr4-runtime-osgi where it should match the Maven module name org.antlr.antlr4-runtime (drop -osgi).

This is causing issues in languages that allow importing modules from Maven but also respect OSGi module information.

This was correct in https://github.com/antlr/antlr4/pull/689/files#r18112858 but got messed up in 8beec18#diff-55b8a2a8dce2483a68f7e139ef5a9a42R51 for I don't know which reason.
@parrt parrt mentioned this issue Dec 10, 2016
Closed
@parrt parrt added this to the 4.6 milestone Dec 11, 2016
@parrt parrt closed this as completed in 42086ef Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build type:improvement
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
2 participants
@parrt @FroMage