Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX - Webapp display - search is difficult #18

Closed
bam-charlesbo opened this issue Dec 19, 2022 · 2 comments
Closed

UX - Webapp display - search is difficult #18

bam-charlesbo opened this issue Dec 19, 2022 · 2 comments
Labels
enhancement New feature or request road-to-v1 features planned to be added for v1

Comments

@bam-charlesbo
Copy link

bam-charlesbo commented Dec 19, 2022

I really like your tool,

Therefore I am making suggestions to see it evolve.

Once the graph is displayed, like this :
Capture d’écran 2022-12-19 à 18 02 15

It would be great to add these features :

  • underline the specified file as parameter
    • with command for example skott src/pages/PaymentPage/PaymentPage.component.tsx, I would like to see the item PaymentPage.component.tsx highlighted
  • allow browser text search (cmd + F)
    • OR create your own search and highlight searched item

By the way I would be pleased to help you on this.

Let me know if you find my suggestions useful,

You can contact me on : charlesbo@bam.tech

@antoine-coulon
Copy link
Owner

antoine-coulon commented Dec 19, 2022

@bam-charlesbo

Thanks to you for providing some super useful feedback!

You're completely right, I have been personally using the tool on the enterprise projects I'm working on and it's true that the visualisation is clearly not ideal for a real-world graph. Searching specific components is very tedious at the moment, so there is clearly room for improvement :)

To be honest, I targeted a minimalist UI for the first release including this new display mode (just got out recently).

It turns out that the "custom search" you suggested is something that I planned to add in the next versions of the app, so I'm very happy to see that we both consider that feature useful.

For the entry point highlight, nice one, I didn't even think about that, it's indeed a great idea!

I would be pleased if you could initiate some work on it!

Feel free to land some PRs and open discussions directly here on GitHub (I'm not really active elsewhere unfortunately), it will also enhance the visibility of the work in progress for everyone coming here and avoiding duplicate issues/feature requests

@antoine-coulon antoine-coulon added enhancement New feature or request road-to-v1 features planned to be added for v1 labels Dec 21, 2022
@antoine-coulon
Copy link
Owner

A new version of skott (v0.14.1) and skott-webapp just came out including the features mentioned in #25. I'm closing this one but feel free to open another issue to suggest other enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request road-to-v1 features planned to be added for v1
Projects
None yet
Development

No branches or pull requests

2 participants