Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't seem to correctly find aliases in tsconfig #20

Closed
fregante opened this issue Dec 26, 2022 · 3 comments · Fixed by #21
Closed

It doesn't seem to correctly find aliases in tsconfig #20

fregante opened this issue Dec 26, 2022 · 3 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@fregante
Copy link

You can see my config at https://github.com/pixiebrix/pixiebrix-extension/blob/ae55fca9e0c610c801f05107f2cde021db09ef0f/tsconfig.json#L19-L26

I'm using a similar config in Madge and I think that one works: https://github.com/pixiebrix/pixiebrix-extension/blob/ae55fca9e0c610c801f05107f2cde021db09ef0f/package.json#L22

 npx skott src/pageScript/pageScript.ts --trackBuiltinDependencies --trackThirdPartyDependencies --displayMode=file-tree

 Running Skott from entrypoint: src/pageScript/pageScript.ts

 Processed 1 file (13.471ms)

 ✓ no circular dependencies found (depth=Infinity)

  pageScript.ts

 npm third-party dependencies: 

  @/contentScript (imports=1)
  @/frameworks (imports=1)
  @/messaging (imports=1)
  @/pageScript (imports=1)
  @/runtime (imports=1)
  @/types (imports=1)
  @/utils (imports=1)
  @/vendors (imports=1)
  lodash (imports=1)

 ✓ no builtin dependencies found

 Skott exited with code 0
@antoine-coulon
Copy link
Owner

Hello @fregante

Thanks for reporting that issue!
🙂

You're right, it seems that it does not resolve correctly your path aliases, I didn't cover the "@/" alias correctly, that's why it turns out that skott considers them in a fallback way as third party dependencies.

I'm going to fix that very quickly so that you'll be able to use skott on the great PixieBrix extension 👌

Thanks again!

@antoine-coulon
Copy link
Owner

Hello @fregante,

Just published a v0.12.3 of skott embedding a fix for this issue.

I tried skott src/pageScript/pageScript.ts --trackBuiltinDependencies --trackThirdPartyDependencies --displayMode=file-tree and it seems to resolve correctly path aliases now.

Feel free to re-open this issue or a new one if you ever notice the same or another problem, thanks to you we just made Skott better 😄

@fregante
Copy link
Author

fregante commented Dec 28, 2022

Thank you! Will try it soon

Edit: it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants