Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register function is not properly exported in TS definition #379

Closed
rdhainaut opened this issue Oct 25, 2022 · 3 comments
Closed

register function is not properly exported in TS definition #379

rdhainaut opened this issue Oct 25, 2022 · 3 comments
Labels
bug Something isn't working fixed The issues was fixed

Comments

@rdhainaut
Copy link

rdhainaut commented Oct 25, 2022

Describe the bug

register function is not properly exported in TS definitions
So, it s not possible to use properly register function in typescript project and vue-advanced-chat component without an compilation error...

Steps to reproduce

I have created a repo https://github.com/rdhainaut/vue-advanced-chat-register-issue
Note: I have generated a basic vue 2 project from vue-cli (with typescript)

Expected behavior

no error in ts project

Fix

//vue-advanced-chat/types.index.d.ts
export function register(): void;
@rdhainaut rdhainaut added the bug Something isn't working label Oct 25, 2022
@antoine92190
Copy link
Collaborator

Thanks, could you open a PR with the fix?

@rdhainaut
Copy link
Author

rdhainaut commented Oct 26, 2022

@antoine92190
I have submitted a pull request with the fix
#381

@antoine92190
Copy link
Collaborator

Thx!

@antoine92190 antoine92190 added the fixed The issues was fixed label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed The issues was fixed
Projects
None yet
Development

No branches or pull requests

2 participants