Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User message avatar slot is only displayed when avatar has a value #386

Closed
NINI1988 opened this issue Nov 8, 2022 · 1 comment · Fixed by #390
Closed

User message avatar slot is only displayed when avatar has a value #386

NINI1988 opened this issue Nov 8, 2022 · 1 comment · Fixed by #390
Labels
bug Something isn't working

Comments

@NINI1988
Copy link
Contributor

NINI1988 commented Nov 8, 2022

Describe the bug

48092be#diff-f3d6d7397d0e697abbf31431377ad9b953fe312e3cf9267331d2e2984ed9b529R37-R45

We want to overwrite the message avatar slot.
But the message avatar slot is only displayed when message.avatar has a value, so we set it for example to true,
and before it is possible to overwrite the message-avatar_ slot a request is already made to request the avatar for the background image true.

Our avatar is generated from multiple images, so it is not possible to just use one url in avatar.

Proposal

Split v-if="message.avatar && message.senderId !== currentUserId"
into v-if="message.senderId !== currentUserId"
and move the first part of v-if="message.avatar" to the inner div.

Device (please complete the following information)

  • OS: Windows 10
  • Browser: Chrome 105.0.5195.127
  • Package version: 2.0.4
@NINI1988 NINI1988 added the bug Something isn't working label Nov 8, 2022
@antoine92190
Copy link
Collaborator

Yes makes sense, feel free to send a PR for that change

antoine92190 added a commit that referenced this issue Nov 22, 2022
Custom room avatars are be displayed without setting avatar url. fix #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants