Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element selectors fix #368 #392

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

NINI1988
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

@antoine92190
Copy link
Collaborator

Why did you remove footerHeight? It's useful in case we want to show emojis, templates, after adding images to a message.

@NINI1988
Copy link
Contributor Author

My Firefox says, that property bottom has no affect on that element, because it's static or something like that. Maybe I missed something, but have you tried it?

@antoine92190
Copy link
Collaborator

Yes I have tried it and it breaks the emoji / tags / templates UI

@NINI1988
Copy link
Contributor Author

I have disabled the file upload in my application, maybe that's the difference. Without an image it works as expected. I will fix it when I have time.

@NINI1988
Copy link
Contributor Author

It works in firefox and chrome as expected. Which browser do you use and how does it look like?

FilesAndEmojis

@antoine92190
Copy link
Collaborator

Actually it works, I don't know what happened last time...

@antoine92190 antoine92190 merged commit 0186ae0 into advanced-chat:master Nov 26, 2022
@NINI1988 NINI1988 deleted the fix-multiple-chat-windows branch November 26, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch more messages does not work with multiple chat windows
2 participants