Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make roomTexteare scrollable #402

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

NINI1988
Copy link
Contributor

Limit the max size of the multiline room textarea to 100px and add scrollbars.
If the textarea is getting to big, it will move out other content.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing

If adding a new feature, the PR's description includes:

Other information:

@antoine92190
Copy link
Collaborator

100px is very small on desktop.
I think max-height should be relative to the chat height, for example 50% as the Telegram desktop app for example.

@NINI1988
Copy link
Contributor Author

Good idea. But with css max-height: 50%; it doesn't work.

@antoine92190
Copy link
Collaborator

I found a compromise using media query

@antoine92190 antoine92190 merged commit b6e6a2e into advanced-chat:master Nov 26, 2022
@NINI1988 NINI1988 deleted the textareaScrollable branch November 26, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants