Possibly disable needle animation ?

[lgodard]

in some use cases (eg. server-side convert to png) the needle animation has to be disabled

passing config.animationDuration = 0 is not a possibility as the constructor test evaluates it to false and then uses the CONSTANT.NEEDLE_ANIMATION_DURATION

many possibilities

1. using config.animationDuration = 0.001 works (hackish though)
2. change CONSTANT.NEEDLE_ANIMATION_DURATION default value to 0 - the animation will be defined but with instant evaluation
3. creates a boolean deactivateAnimation and modify Needleclass accordingly
4. creates an animation object property and only set the animation if defined

animation: {
  duration: 3000,
  delay: 0
}

I personally would prefer option 4. (or 2.)

Any opinion ?

[antoinebeland]

Hi @lgodard,

I think the easier and more elegant solution is to change condition in the constructor. Instead to do the following condition to set the animation duration,

this._animationDuration = config.animationDuration || CONSTANTS.NEEDLE_ANIMATION_DURATION;

It will be better if I changed this condition by the following:

this._animationDuration = (config.animationDuration !== undefined) 
  ?  config.animationDuration 
  : CONSTANTS.NEEDLE_ANIMATION_DURATION;

Thus, it will be possible to set the animationDuration to 0 without any other changes.