-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(methods): use private when necessary #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinezanardi
added
the
🔩 refactor
Code change that neither fixes a bug nor adds a feature
label
Jun 3, 2023
Kudos, SonarCloud Quality Gate passed! |
antoinezanardi
pushed a commit
that referenced
this pull request
Jun 17, 2023
## [1.10.0](v1.9.0...v1.10.0) (2023-06-17) ### 🚀 Features * **game-maker:** game play methods ([#229](#229)) ([aa1c954](aa1c954)) * **game:** get game by id pipe in controller ([#211](#211)) ([bb1e34f](bb1e34f)) ### 🔩 Refactor * **game:** get playing game helper removed ([#214](#214)) ([e2cfd8a](e2cfd8a)) * **methods:** use private when necessary ([#217](#217)) ([42a81ab](42a81ab)) * **tests:** better readability and mocks ([#224](#224)) ([410715c](410715c)) ### ✅ Tests * **mongoose:** object id factory ([#215](#215)) ([81d7f9e](81d7f9e)) ### 🧹 Chore * **deps:** bump @commitlint/cli from 17.6.3 to 17.6.5 ([#210](#210)) ([44b8128](44b8128)) * **deps:** bump @commitlint/config-conventional from 17.6.3 to 17.6.5 ([#208](#208)) ([aafc9f7](aafc9f7)) * **deps:** bump @faker-js/faker from 8.0.1 to 8.0.2 ([#207](#207)) ([3020acc](3020acc)) * **deps:** bump @nestjs/cli from 10.0.1 to 10.0.2 ([#252](#252)) ([dc83b18](dc83b18)) * **deps:** bump @nestjs/cli from 9.5.0 to 10.0.1 ([#250](#250)) ([f717f33](f717f33)) * **deps:** bump @nestjs/common from 9.4.2 to 9.4.3 ([#237](#237)) ([25eaeaf](25eaeaf)) * **deps:** bump @nestjs/config from 2.3.2 to 2.3.3 ([#243](#243)) ([5d67fed](5d67fed)) * **deps:** bump @nestjs/config from 2.3.3 to 2.3.4 ([#245](#245)) ([1d323d1](1d323d1)) * **deps:** bump @nestjs/config from 2.3.4 to 3.0.0 ([#249](#249)) ([a254172](a254172)) * **deps:** bump @nestjs/core from 9.4.2 to 9.4.3 ([#235](#235)) ([c1e6e91](c1e6e91)) * **deps:** bump @nestjs/mongoose from 9.2.2 to 10.0.0 ([#251](#251)) ([3fe60fb](3fe60fb)) * **deps:** bump @nestjs/platform-express from 9.4.2 to 9.4.3 ([#234](#234)) ([d56efbc](d56efbc)) * **deps:** bump @nestjs/platform-fastify from 9.4.2 to 9.4.3 ([#241](#241)) ([dcb1582](dcb1582)) * **deps:** bump @nestjs/schematics from 9.2.0 to 10.0.1 ([#248](#248)) ([a5a6a26](a5a6a26)) * **deps:** bump @nestjs/swagger from 6.3.0 to 7.0.0 ([#253](#253)) ([3e60868](3e60868)) * **deps:** bump @nestjs/terminus from 9.2.2 to 10.0.0 ([#255](#255)) ([d2f9750](d2f9750)) * **deps:** bump @nestjs/testing from 9.4.2 to 9.4.3 ([#239](#239)) ([91d78f7](91d78f7)) * **deps:** bump @stryker-mutator/jest-runner from 6.4.2 to 7.0.0 ([#218](#218)) ([33d989e](33d989e)) * **deps:** bump @stryker-mutator/typescript-checker from 6.4.2 to 7.0.0 ([#221](#221)) ([b1d3b6f](b1d3b6f)) * **deps:** bump @types/jest from 29.5.1 to 29.5.2 ([#213](#213)) ([10bcfc9](10bcfc9)) * **deps:** bump @types/node from 20.2.4 to 20.2.5 ([#206](#206)) ([492e9b2](492e9b2)) * **deps:** bump @types/node from 20.2.5 to 20.3.0 ([#232](#232)) ([34a0cec](34a0cec)) * **deps:** bump @types/node from 20.3.0 to 20.3.1 ([#236](#236)) ([d342c3f](d342c3f)) * **deps:** bump @typescript-eslint/eslint-plugin from 5.59.7 to 5.59.8 ([#205](#205)) ([4da8dd0](4da8dd0)) * **deps:** bump @typescript-eslint/eslint-plugin from 5.59.8 to 5.59.9 ([#226](#226)) ([36ee256](36ee256)) * **deps:** bump @typescript-eslint/eslint-plugin from 5.59.9 to 5.59.11 ([#238](#238)) ([324be15](324be15)) * **deps:** bump @typescript-eslint/parser from 5.59.7 to 5.59.8 ([#204](#204)) ([4c48548](4c48548)) * **deps:** bump @typescript-eslint/parser from 5.59.8 to 5.59.9 ([#227](#227)) ([326e5fd](326e5fd)) * **deps:** bump @typescript-eslint/parser from 5.59.9 to 5.59.11 ([#242](#242)) ([2cdc497](2cdc497)) * **deps:** bump eslint from 8.41.0 to 8.42.0 ([#219](#219)) ([7ebdfc1](7ebdfc1)) * **deps:** bump eslint from 8.42.0 to 8.43.0 ([#256](#256)) ([f50b4de](f50b4de)) * **deps:** bump mongoose from 7.2.1 to 7.2.2 ([#209](#209)) ([61c4cc3](61c4cc3)) * **deps:** bump mongoose from 7.2.2 to 7.2.3 ([#231](#231)) ([dfe6b37](dfe6b37)) * **deps:** bump mongoose from 7.2.3 to 7.2.4 ([#240](#240)) ([61e97b1](61e97b1)) * **deps:** bump mongoose from 7.2.4 to 7.3.0 ([#246](#246)) ([808f6c3](808f6c3)) * **deps:** bump radash from 10.8.1 to 10.9.0 ([#254](#254)) ([3b02efa](3b02efa)) * **deps:** bump semantic-release from 21.0.2 to 21.0.3 ([#220](#220)) ([5e7555f](5e7555f)) * **deps:** bump semantic-release from 21.0.3 to 21.0.5 ([#233](#233)) ([063b901](063b901)) * **deps:** bump typescript from 5.0.4 to 5.1.3 ([#216](#216)) ([bd80920](bd80920)) * **jest:** adapt tests to jest-extended v4 ([#257](#257)) ([645ca7e](645ca7e)) * **script:** allow numbers in git branches ([#223](#223)) ([4a328d6](4a328d6))
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.