Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(game-play-validator): use game source methods for validations #300

Merged
merged 1 commit into from
Jul 1, 2023
Merged

refactor(game-play-validator): use game source methods for validations #300

merged 1 commit into from
Jul 1, 2023

Conversation

antoinezanardi
Copy link
Owner

Closes #262

@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Jul 1, 2023
@antoinezanardi antoinezanardi self-assigned this Jul 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antoinezanardi antoinezanardi merged commit 98b2f53 into develop Jul 1, 2023
10 checks passed
@antoinezanardi antoinezanardi deleted the feat/refactor-game-play-validator branch July 1, 2023 12:06
antoinezanardi pushed a commit that referenced this pull request Jul 7, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
d64c29d 
## [1.12.0](v1.11.0...v1.12.0) (2023-07-07)

### 🚀 Features

* **dependabot:** group some deps together ([#317](#317)) ([a3d7377](a3d7377))
* **game-play:** handle sheriff election tie in votes ([#314](#314)) ([09c8606](09c8606))
* **player-attribute:** decreasing and outcomes ([#279](#279)) ([a5c8b6b](a5c8b6b))

### 🔩 Refactor

* **game-play-validator:** use game source methods for validations ([#300](#300)) ([98b2f53](98b2f53))
* **game-play:** rename some services ([#293](#293)) ([01df850](01df850))

### 🔁 CI

* **pr-names:** linter for pull requests name ([#302](#302)) ([2c2a8e5](2c2a8e5))

### 🧹 Chore

* **deps:** bump @commitlint/cli from 17.6.5 to 17.6.6 ([d45513b](d45513b))
* **deps:** bump @commitlint/config-conventional from 17.6.5 to 17.6.6 ([01b2fe6](01b2fe6))
* **deps:** bump @nestjs/cli from 10.0.3 to 10.0.5 ([ee48eef](ee48eef))
* **deps:** bump @nestjs/cli from 10.0.5 to 10.1.1 ([#307](#307)) ([ebb0341](ebb0341))
* **deps:** bump @nestjs/cli from 10.1.1 to 10.1.4 ([#313](#313)) ([30164b1](30164b1))
* **deps:** bump @nestjs/cli from 10.1.4 to 10.1.7 ([#315](#315)) ([1866459](1866459))
* **deps:** bump @nestjs/swagger from 7.0.10 to 7.0.11 ([#294](#294)) ([924734b](924734b))
* **deps:** bump @nestjs/swagger from 7.0.11 to 7.0.12 ([#299](#299)) ([f26d21a](f26d21a))
* **deps:** bump @nestjs/swagger from 7.0.12 to 7.1.1 ([#310](#310)) ([460e242](460e242))
* **deps:** bump @nestjs/swagger from 7.0.4 to 7.0.6 ([f7a1f9f](f7a1f9f))
* **deps:** bump @nestjs/swagger from 7.0.6 to 7.0.10 ([#291](#291)) ([7afad8c](7afad8c))
* **deps:** bump @types/node from 20.3.1 to 20.3.2 ([63f6f58](63f6f58))
* **deps:** bump @types/node from 20.3.2 to 20.3.3 ([#303](#303)) ([350c05a](350c05a))
* **deps:** bump @types/node from 20.3.3 to 20.4.0 ([#316](#316)) ([bc6c2a1](bc6c2a1))
* **deps:** bump @typescript-eslint/eslint-plugin from 5.60.0 to 5.60.1 ([9930d12](9930d12))
* **deps:** bump @typescript-eslint/eslint-plugin from 5.60.1 to 5.61.0 ([#308](#308)) ([1711d9d](1711d9d))
* **deps:** bump @typescript-eslint/parser from 5.60.0 to 5.60.1 ([c7d8388](c7d8388))
* **deps:** bump @typescript-eslint/parser from 5.60.1 to 5.61.0 ([#309](#309)) ([1ee5d86](1ee5d86))
* **deps:** bump eslint from 8.43.0 to 8.44.0 ([#306](#306)) ([f7269d9](f7269d9))
* **deps:** bump jest from 29.5.0 to 29.6.0 ([#312](#312)) ([6c4cf4d](6c4cf4d))
* **deps:** bump jest from 29.6.0 to 29.6.1 ([#319](#319)) ([c705ae1](c705ae1))
* **deps:** bump lint-staged from 13.2.2 to 13.2.3 ([#298](#298)) ([6ff0285](6ff0285))
* **deps:** bump mongoose from 7.3.1 to 7.3.2 ([#318](#318)) ([910878a](910878a))
* **deps:** bump radash from 10.9.0 to 11.0.0 ([#290](#290)) ([ed28c3e](ed28c3e))
* **deps:** bump semantic-release from 21.0.5 to 21.0.6 ([#296](#296)) ([525208f](525208f))
* **deps:** bump semantic-release from 21.0.6 to 21.0.7 ([#311](#311)) ([fef3c53](fef3c53))
* **deps:** bump ts-jest from 29.1.0 to 29.1.1 ([#304](#304)) ([234f87c](234f87c))
* **deps:** bump ts-loader from 9.4.3 to 9.4.4 ([#295](#295)) ([c8d0e98](c8d0e98))
* **deps:** bump typescript from 5.1.3 to 5.1.5 ([#292](#292)) ([c5fd6e0](c5fd6e0))
* **deps:** bump typescript from 5.1.5 to 5.1.6 ([#297](#297)) ([17f745d](17f745d))
* **stryker:** update to stryker 7.1 ([#301](#301)) ([32a2e33](32a2e33))
@antoinezanardi
Copy link
Owner Author

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@antoinezanardi antoinezanardi

Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@antoinezanardi