Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(globals): correct UPPER_CASE casing for globals #446

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

antoinezanardi
Copy link
Owner

No description provided.

@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Aug 28, 2023
@antoinezanardi antoinezanardi self-assigned this Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antoinezanardi antoinezanardi merged commit 669ffa1 into develop Aug 29, 2023
12 checks passed
@antoinezanardi antoinezanardi deleted the feat/constant-case branch August 29, 2023 12:34
@antoinezanardi antoinezanardi linked an issue Aug 29, 2023 that may be closed by this pull request
antoinezanardi pushed a commit that referenced this pull request Sep 9, 2023
## [1.17.0](v1.16.0...v1.17.0) (2023-09-09)

### 🚀 Features

* **cucumber:** publish report on release ([#451](#451)) ([f13f190](f13f190))

### 📖 Docs

* **readme:** improved tests section ([#450](#450)) ([68173ef](68173ef))

### 🔩 Refactor

* **constants:** constants for game schemas ([#467](#467)) ([f8331f6](f8331f6))
* **globals:** correct UPPER_CASE casing for globals ([#446](#446)) ([669ffa1](669ffa1))
* **object-id:** use equal method for comparison ([#473](#473)) ([267d56f](267d56f))
* **paths:** path aliases for src and tests ([#440](#440)) ([5d19d5c](5d19d5c))

### ✅ Tests

* **acceptance:** acceptances tests for raven ([#459](#459)) ([0e29af5](0e29af5))
* **acceptance:** acceptances tests for three brothers ([#458](#458)) ([df6c976](df6c976))
* **acceptance:** acceptances tests for two sisters ([#455](#455)) ([caa3960](caa3960))
* **acceptance:** sheriff player attribute acceptance tests ([#472](#472)) ([ed9e09e](ed9e09e))
* **acceptance:** stuttering judge acceptance tests ([#469](#469)) ([8a759c3](8a759c3))
* **player:** fix player with name randomness test ([#454](#454)) ([d5cb70a](d5cb70a))

### 🧹 Chore

* **deps:** bump @cucumber/cucumber from 9.4.0 to 9.5.0 ([#463](#463)) ([e1af320](e1af320))
* **deps:** bump @cucumber/cucumber from 9.5.0 to 9.5.1 ([#470](#470)) ([49dd67d](49dd67d))
* **deps:** bump @fastify/static from 6.10.2 to 6.11.0 ([#462](#462)) ([e0ad49a](e0ad49a))
* **deps:** bump mongoose from 7.4.4 to 7.4.5 ([#444](#444)) ([64a4e40](64a4e40))
* **deps:** bump mongoose from 7.4.5 to 7.5.0 ([#453](#453)) ([295f1e8](295f1e8))
* **deps:** bump the eslint group with 1 update ([#443](#443)) ([ab3d1f7](ab3d1f7))
* **deps:** bump the eslint group with 2 updates ([#449](#449)) ([b3472bd](b3472bd))
* **deps:** bump the eslint group with 2 updates ([#466](#466)) ([2676eec](2676eec))
* **deps:** bump the nest group with 1 update ([#452](#452)) ([4de05c6](4de05c6))
* **deps:** bump the nest group with 5 updates ([#447](#447)) ([858fc29](858fc29))
* **deps:** bump the nest group with 5 updates ([#457](#457)) ([2aae75b](2aae75b))
* **deps:** bump the nest group with 7 updates ([#460](#460)) ([122e5cb](122e5cb))
* **deps:** bump the types group with 1 update ([#442](#442)) ([17478da](17478da))
* **deps:** bump the types group with 1 update ([#461](#461)) ([f87108d](f87108d))
* **deps:** bump the types group with 1 update ([#468](#468)) ([3e908ee](3e908ee))
* **deps:** bump the types group with 2 updates ([#465](#465)) ([4130ed1](4130ed1))
* **deps:** bump type-fest from 4.2.0 to 4.3.1 ([#445](#445)) ([6a800fb](6a800fb))
* **github-actions:** bump actions/checkout from 3 to 4 ([#464](#464)) ([834a156](834a156))
@antoinezanardi
Copy link
Owner Author

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change case of constants to UPPER_CASE
1 participant