Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(constants): deep readonly for all constants and consistent way of declare mongoose props #568

Merged
merged 5 commits into from
Oct 14, 2023

Conversation

antoinezanardi
Copy link
Owner

Closes #564

@antoinezanardi antoinezanardi added the 🧹 chore Some boring (or not) task label Oct 12, 2023
@antoinezanardi antoinezanardi self-assigned this Oct 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antoinezanardi antoinezanardi merged commit 72ed7b3 into develop Oct 14, 2023
14 checks passed
@antoinezanardi antoinezanardi deleted the feat/read-only-deep-for-constants branch October 14, 2023 15:20
antoinezanardi pushed a commit that referenced this pull request Oct 14, 2023
## [1.20.0](v1.19.0...v1.20.0) (2023-10-14)

### 🚀 Features

* **game-play:** occurrences for game plays ([#558](#558)) ([fdf28d0](fdf28d0))

### ✅ Tests

* **acceptance:** acceptance tests for current game play source players ([#548](#548)) ([286d4f8](286d4f8))
* **acceptance:** acceptance tests villager-villager role ([#566](#566)) ([879999c](879999c))
* **acceptance:** acceptance tests werewolf role ([#565](#565)) ([8cdb589](8cdb589))

### 🔁 CI

* **release:** fetch-depth set to 0 to merge main into develop ([#551](#551)) ([fd497cc](fd497cc))
* **release:** merge main into develop before running semantic release ([9c1fd27](9c1fd27))
* **release:** merge main into develop before running semantic release ([#550](#550)) ([ab46912](ab46912))

### 🧹 Chore

* **branch-name:** expand possible branch prefixes ([#570](#570)) ([d5a7d79](d5a7d79))
* **commands:** run commands are available undeer the .run directory ([#567](#567)) ([b36ee52](b36ee52)), closes [#547](#547)
* **constants:** deep readonly for all constants and consistent way of declare mongoose props ([#568](#568)) ([72ed7b3](72ed7b3)), closes [#564](#564)
* **deps:** bump @cucumber/cucumber from 9.5.1 to 9.6.0 ([#556](#556)) ([53bd156](53bd156))
* **deps:** bump @cucumber/cucumber from 9.6.0 to 10.0.0 ([#561](#561)) ([17361b4](17361b4)), closes [/github.com/cucumber/cucumber-js/blob/main/UPGRADING.md#1000](https://github.com/antoinezanardi//github.com/cucumber/cucumber-js/blob/main/UPGRADING.md/issues/1000) [#2331](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2331) [#2334](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2334) [#2334](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2334) [#2337](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2337) [#2260](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2260) [#2331](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2331) [#2331](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2331) [#2334](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2334) [#2334](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2334) [#2337](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2337) [#2260](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2260) [#2331](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2331) [#2337](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2337) [#2336](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2336) [#2334](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2334) [#2330](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2330) [#2261](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2261) [#2331](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/2331)
* **deps:** bump mongoose from 7.5.4 to 7.6.0 ([#557](#557)) ([ca953b6](ca953b6))
* **deps:** bump mongoose from 7.6.0 to 7.6.1 ([#562](#562)) ([b1c8d2a](b1c8d2a))
* **deps:** bump the eslint group with 1 update ([#553](#553)) ([6439751](6439751))
* **deps:** bump the jest group with 1 update ([#560](#560)) ([2b0701e](2b0701e))
* **deps:** bump the types group with 1 update ([#552](#552)) ([07d669d](07d669d))
* **deps:** bump the types group with 1 update ([#563](#563)) ([56d254c](56d254c))
* **deps:** bump the types group with 1 update ([#569](#569)) ([b4e8c98](b4e8c98))
* **deps:** bump the types group with 3 updates ([#559](#559)) ([8b5a977](8b5a977))
* **deps:** bump ts-loader from 9.4.4 to 9.5.0 ([#555](#555)) ([7bb987d](7bb987d))
* **deps:** bump type-fest from 4.3.3 to 4.4.0 ([#554](#554)) ([25cb4ef](25cb4ef)), closes [#682](#682) [#682](#682)
@antoinezanardi
Copy link
Owner Author

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 chore Some boring (or not) task released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant