Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves docs a bit #121

Merged
merged 2 commits into from Jul 9, 2021
Merged

Improves docs a bit #121

merged 2 commits into from Jul 9, 2021

Conversation

sobolevn
Copy link
Contributor

@sobolevn sobolevn commented Jul 6, 2021

  1. Adds links to types that we are talking about
  2. Adds .. code-block:: python in all places, otherwise this code was not highlighted on github

I really hope that RTD will build my PR to test it out, I am too lazy to test it locally 馃槅

1. Adds links to types that we are talking about
2. Adds `.. code-block:: python` in all places, otherwise this code was not highlighted on github
@sobolevn
Copy link
Contributor Author

sobolevn commented Jul 6, 2021

Looks like it will 馃帀

@sobolevn
Copy link
Contributor Author

sobolevn commented Jul 6, 2021

Looks like it won't 馃槥
小薪懈屑芯泻 褝泻褉邪薪邪 2021-07-06 胁 8 38 20

@sobolevn
Copy link
Contributor Author

sobolevn commented Jul 6, 2021

Some unrelated updates:

Thanks a lot for your hard work! 馃憤

@antonagestam
Copy link
Owner

Thanks for the patch, it's first one for this package! 馃帀

Hmm, seems like the coverage setup isn't working, I'll look into it!

@antonagestam antonagestam merged commit 9b76f6f into antonagestam:main Jul 9, 2021
@antonagestam
Copy link
Owner

Thanks for the patch @sobolevn! 馃嵃 I switched to something more conventional for coverage reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants