You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I know the official alpha-2 code is GB and UK is part of the "exceptional reservations" list of iso3166-1 alpha-2, but frankly, all addresses in Great Britain have a post code of UK.
I think it could be useful to include UK as well, in cases where one wants to use e.g. country: CountryCode for address validation or the like.
The text was updated successfully, but these errors were encountered:
Your proposal completely changes the meaning of the CountryCode type, and I think it'd be very hard to convince me a non standards confirming type is more useful.
An alternative would be to introduce a new type, but I'm not sure what that type should be to fit your usecase. Doesn't addresses usually just have the full name of the country? E.g. "United Kingdom" in your case?
FWIW I believe french is the official international postal language so, technically "La Suède" is as correct as "Sweden" on a parcel sent to Sweden. What I'm trying to get at is that I don't think that it makes sense for the CountryCode type to have the ability to determine whether or not an address country is correct, and I'm not confident such ability fits here. Wdyt? I'm open to further discussion!
Think I opened this issue a bit hastily, and indeed one could perhaps go for a verbose value of the code GB to be UK.
What I initially got in trouble with was aligning with other parties. But so, if they claim to follow the iso3166-1 alpha 2 standard there shouldn't really be any problem one have to overcome.
I know the official alpha-2 code is
GB
andUK
is part of the "exceptional reservations" list ofiso3166-1 alpha-2
, but frankly, all addresses in Great Britain have a post code ofUK
.I think it could be useful to include
UK
as well, in cases where one wants to use e.g.country: CountryCode
for address validation or the like.The text was updated successfully, but these errors were encountered: