Add albums #20
Add albums #20
Conversation
|
|
||
| fun transform(artists: List<LastFmArtist>): List<Artist> { | ||
| return artists.filter { artistHasQualityInfo(it) }.map { transform(it) } | ||
| return artists.take(10).filter { artistHasQualityInfo(it) }.map { transform(it) } |
There was a problem hiding this comment.
Artist without mbid that makes app unusable is in the end of the list.
This is a temporary solution of that problem, that is addressed more fundamentally here #16
|
Thanks @pvg-alex ! I'll give a go to all your work these days. |
|
Thank you. This issue is addressed here too btw #17 |
|
|
||
| lastFmService = restAdapter.create(LastFmService::class.java) ; |
There was a problem hiding this comment.
Thanks for the little cleanup 😳
|
For some reason I get an empty screen when running the code. I can't continue today, I'll try to debug it one of this days, but any ideas will be welcomed @pvg-alex . Code looks great, so it's just a matter of taking a look and see if UI looks good too. EDIT: Ah, ok, I see the problem is #16. So let's merge that one first, and then please rebase this branch so that it works. I did myself but there are some conflicts that I prefer you to deal with. |
Conflicts: app/build.gradle app/src/main/java/com/antonioleiva/bandhookkotlin/data/mapper/ArtistMapper.kt app/src/main/java/com/antonioleiva/bandhookkotlin/repository/ArtistRepositoryImp.kt
|
Looks great @pvg-alex ! Would it be too difficult to make the card scroll up while the background image does a parallax? I'd also agree to merge it as it is now and do it on a separate PR. so that this PR doesn't keep growing. |
|
Thanks @antoniolg |
|
Great, as you wish. Not a big deal anyway. Merging this. Thanks again! |
Description
Add albums to the app.
Artist albums are shown in the activity that used to be called DetailActivity, now it is called ArtistActivity.
Biography and albums are shown in a view pager with tabs similar to the approach used in the original bandhook app.
I've migrated artist activity to use design support library from ObservableScrollView, that makes the code simpler.
And there is also an activity to show an album, that looks like the image in the issue.