Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for chapters in this repo #4

Closed
Ks89 opened this issue Nov 25, 2015 · 4 comments
Closed

Suggestion for chapters in this repo #4

Ks89 opened this issue Nov 25, 2015 · 4 comments

Comments

@Ks89
Copy link

Ks89 commented Nov 25, 2015

Hi Antonio,
why are you using commits and not branches to specify different chapters? XD It's only an idea.

@antoniolg
Copy link
Owner

I had it that way at the beginning, but it was much more difficult to maintain. This book (and repository) has been updated on any new Kotlin release, and that implied modifying all the branches affected by language modifications. If there was a change in one of the first commits, I had to redo the main branch and all the secondary branches, which was a painful job and didn't provide any big advantages.

You can checkout individual commits and have the same result, and it's really easy from Android Studio "version control" panel.

@shekibobo
Copy link

You could also tag the commits for each relevant chapter to make them easier to check out from local source control:

git checkout <commit>
git tag chapter-01
git push --tags

@antoniolg
Copy link
Owner

If you think it's useful, that would be easy. But all the commits are relevant, because there's one commit per chapter, so not sure it would add much simplicity.

@shekibobo
Copy link

it's just one less step if I want to skip between chapter code, rather than looking up the commit and checking it out, I could just checkout chapter-10. Predictable. However, if you rewrite the whole repo when there are updates, you'd need to redo the tags on the new commits and force push them. So that's an extra step on your part. Just a suggestion. Thanks for the great introduction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants