Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto close ssh connection if couldn't create the requested subdomain #181

Closed
wants to merge 1 commit into from

Conversation

zk-steve
Copy link
Contributor

…omain

@zk-steve
Copy link
Contributor Author

Please, check this pull request

@antoniomika
Copy link
Owner

Hey @sonntuet1997,

This was actually intentionally. Because clients can ask for multiple forwards, we don't want to close the connection until all forwards are complete (or the client requests it). But because sish supports local forwards (direct-tcpip), we don't know if clients are done with their connection until they disconnect. Sorry it took so long for me to respond here.

I'll be closing this for the above. I was thinking maybe we could have clients that use a local forward tell clinc so? I want to still try to stick as much to the ssh semantics as possible though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants