Linking lines are broken after page resize

[bogomya]

[antonioru]

Thank you for pointing this out @bogomya
I'll have a look at it as soon as possible

[alexratmanpl]

Hi @antonioru
That's very annoying bug indeed - when working with more nodes, especially when you have to place them inside a scrollable 'div', there's no way to link and manipulate them correctly - I would be very happy to use your tool in my project but because of that bug it's not possible.
You probably could fix that very easily by modifying useEffect function in DiagramCanvas.js and let it refresh the current position of canvas on each update, something like:
useEffect(() => calculateBBox(canvasRef.current));
In that case I suppose you may consider removing useWindowScroll hook as well.
Btw. great job, simple tool, clean code - it was kind of pleasure to search for a possible solution of fixing that bug. Congrats!

[antonioru]

@alexratmanpl @bogomya

Thank you for pointing this out and supporting the project, I can't wait to work again on it as I really love this library.
I hope to do it as soon as possible so I can fix this precise bug and bring new improvements.
Unfortunately at the moment I am quite busy with work and personal life, but I would love to have some contributions.
Please feel free to open a PR

thank you

[volkan-a]

Hi @antonioru, is there any progress? I really would like to use on my project.

[antonioru]

Hi @antonioru, is there any progress? I really would like to use on my project.

Hi @volkan-a
thank you for your concern, as mentioned in the previous comment: at the moment I am quite busy with work and personal life, but I would love to have some contributions.
If you feel like you need some improvements please feel free to open a PR :)

[volkan-a]

I think @alexratmanpl's suggestion works.

Just change line 31 in DiagramCanvas.js as:

useEffect(() => calculateBBox(canvasRef.current), [canvasRef.current, props]);

then it works. But I have no idea if that affects performance.

[antonioru]

@volkan-a
This is an open source software, meaning everyone is titled to contribute.
If you want, make the change by yourself, test it, make sure it does not break anything and does not affect performances then open a PR.
I will be very happy to look at it.

[antonioru]

@volkan-a @bogomya
Apparently this bugs appears on Firefox only, can you confirm it?

[antonioru]

@volkan-a @bogomya

Ok I think I solved the bug in the last published version: 0.2.0

Please let me know if it works for you as well... I'm going to close the issue.

In case the bug shows up again, please just open a new bug report.

Thank you all for the patience