Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Cleanup #5

Closed
elithrar opened this issue Jun 20, 2015 · 1 comment
Closed

Session Cleanup #5

elithrar opened this issue Jun 20, 2015 · 1 comment

Comments

@elithrar
Copy link
Contributor

From what I can determine, old sessions that have expired but have not been explicitly deleted will remain in the database.

Although this is not a huge problem unto itself, it's a little messy. The boltstore package has a reaper function that operates via a goroutine and a time.Ticker to check the database for old sessions -

e.g.

DELETE FROM http_sessions WHERE expires_on > current_time

I figured I'd raise this issue before submitting a PR (super busy right now!) in the event you can get to a patch before I can.

@antonlindstrom
Copy link
Owner

@elithrar Thanks for bringing this up. There's currently no reaper process involved that's cleaning up old sessions.

If you're able to send a PR that would be awesome, otherwise I'll take a look in a few weeks.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants