Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the number parser to include support for parsing hexadecimal, binary, and octal literals. #483

Merged

Conversation

ckganesan
Copy link
Contributor

The current parser lacks support for the following numeric representations:

  1. Octal literals.
  2. Binary literals.
  3. Hexadecimal literals with a '0X' prefix.

parser/parser.go Outdated Show resolved Hide resolved
parser/parser_test.go Show resolved Hide resolved
@ckganesan
Copy link
Contributor Author

Hello @antonmedv, I kindly request your review of this pull request when you have a moment. Your insights would be greatly appreciated. Thank you in advance for your time and assistance!

@ckganesan ckganesan closed this Dec 8, 2023
@ckganesan ckganesan deleted the enhance-number-support-hex-octel-bin branch December 8, 2023 17:07
@ckganesan ckganesan restored the enhance-number-support-hex-octel-bin branch December 8, 2023 17:10
@ckganesan ckganesan reopened this Dec 8, 2023
@antonmedv antonmedv merged commit 87c6a94 into expr-lang:master Dec 8, 2023
12 of 14 checks passed
@ckganesan ckganesan deleted the enhance-number-support-hex-octel-bin branch December 9, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants