Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Scheduler Duplicates not prevented. #224

Open
guyt101z opened this issue May 25, 2014 · 4 comments
Open

Issue with Scheduler Duplicates not prevented. #224

guyt101z opened this issue May 25, 2014 · 4 comments
Milestone

Comments

@guyt101z
Copy link

Using Webservices to populate scheduler for outgoing SMS. Most Providers block duplicates if sent within a period so this is definitely an important feature to prevent that also don't want to waste time and resources duplicating messages by mistake.. This link has some info to fix. hope it helps someone who can add this fix.

http://www.phponwebsites.com/2014/03/Avoid-duplicate-values-storing-in-table-using-php-and-mysql.html

@antonraharja
Copy link
Member

Can you give me step by step how to produce this bug ?

anton

@guyt101z
Copy link
Author

It can be done using the sender page. Send identical message more than once to the same number scheduled for same time and it will add to the sender queue.I think should not allow this at least the scheduled sending time should be different.

@antonraharja
Copy link
Member

ok, its a little more complex than that link describes, theres smslog_id and remote smslog_id involves.

anyway, its a good idea to do this, I'll see what I can do

@antonraharja antonraharja added this to the trunk milestone May 27, 2014
@guyt101z
Copy link
Author

I do not think the database method in that link will work to fix this issue it is a bit complex. My idea is to convert message and the destination number to a hash then use a check function to ensure it is not repeated. within a period of time. this may require another table in the database but i think this will be a quick easy fix.

@antonraharja antonraharja modified the milestones: 1.1, trunk Oct 9, 2014
@antonraharja antonraharja modified the milestones: 1.1, next Jun 24, 2015
@antonraharja antonraharja modified the milestones: 1.2, next Jul 10, 2015
@antonraharja antonraharja modified the milestones: 1.5, next Jul 17, 2016
@antonraharja antonraharja modified the milestones: 1.5, next Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants