Add support for restrict attribute on function parameters
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
reviewed
Aug 14, 2023
Comment on lines
+493
to
+496
| type *get_restrict () const | ||
| { | ||
| return new type (build_qualified_type (m_inner, TYPE_QUAL_RESTRICT)); | ||
| } |
There was a problem hiding this comment.
not sure how relevant this is to libgccjit, but we got patches "rejected" because of implementations in header files, despite having existing implementations in the same header file. I see that get_aligned and get_vector are declared here, so I assume there's a corresponding jit-playback.cc file where the implementation could live? just a little nit but it could help get the patch approved on the GCC side
There was a problem hiding this comment.
Thanks for the information! I'll give a try like this and if needed, I'll move the function in the source file. But for the time being, for coherency I'll leave it here. :)
antoyo
reviewed
Aug 16, 2023
gcc/jit/libgccjit.map
Outdated
| @@ -104,6 +104,7 @@ LIBGCCJIT_ABI_0 | |||
| gcc_jit_type_as_object; | |||
| gcc_jit_type_get_const; | |||
| gcc_jit_type_get_pointer; | |||
| gcc_jit_type_get_restrict; | |||
There was a problem hiding this comment.
This should be in a new API section, at the end.
gcc/jit/Changelog: * jit-playback.cc: Remove trailing whitespace characters. * jit-playback.h: Add get_restrict method. * jit-recording.cc: Add get_restrict methods. * jit-recording.h: Add get_restrict methods. * libgccjit++.h: Add get_restrict methods. * libgccjit.cc: Add gcc_jit_type_get_restrict. * libgccjit.h: Declare gcc_jit_type_get_restrict. * libgccjit.map: Declare gcc_jit_type_get_restrict. gcc/testsuite/ChangeLog: * jit.dg/test-restrict.c: Add test for __restrict__ attribute. Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
GuillaumeGomez
force-pushed
the
restrict
branch
from
8cafadb
to
840bab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.