Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart.render(true) bug after change facet api #3339

Closed
1 task
KedAyAyA opened this issue Mar 24, 2021 · 3 comments
Closed
1 task

chart.render(true) bug after change facet api #3339

KedAyAyA opened this issue Mar 24, 2021 · 3 comments

Comments

@KedAyAyA
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://codepen.io/KedAyAyA/pen/RwKPpbe

Steps to reproduce

  1. click change facet button
  2. no chart will repaint and leave with a white screen
Environment Info
g2 4.1.13
System Mac
Browser chrome latest
@hustcc
Copy link
Member

hustcc commented Mar 24, 2021

@KedAyAyA 有兴趣来 5.0 来搞这个吗?目前 4.0 的解法可能是完全重新 render。

5.0 有一个点是 render 和 update 直接合并掉。

@KedAyAyA
Copy link
Author

@KedAyAyA 有兴趣来 5.0 来搞这个吗?目前 4.0 的解法可能是完全重来。

5.0 有一个点是 render 和 update 直接合并掉。

可以呀,暂时有个其他的解法,晚点我提个pr看看

@pearmini
Copy link
Member

pearmini commented Dec 5, 2023

4.0 的这个问题不会修复了,可以看看 5.0 的分面。就像 @hustcc 说的一样: “render 和 update 直接合并掉”。

@pearmini pearmini closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants