Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【V5】Tooltip enterable属性是否计划支持? #5620

Closed
fangqi5 opened this issue Oct 8, 2023 · 9 comments · Fixed by #5626
Closed

【V5】Tooltip enterable属性是否计划支持? #5620

fangqi5 opened this issue Oct 8, 2023 · 9 comments · Fixed by #5626
Milestone

Comments

@fangqi5
Copy link

fangqi5 commented Oct 8, 2023

@hustcc
Copy link
Member

hustcc commented Oct 9, 2023

component 中是有 enterable 属性的,不过测试来看,有一些 bug。

@hustcc
Copy link
Member

hustcc commented Oct 9, 2023

@pearmini @Aarebecca 扫描了一遍代码,目前 enterable 做到 component.tooltip 中存在一些问题。

  • 组件本身 .show 因为 throttle 的原因,导致 enterable 配置失效
  • hide 的时候没有鼠标位置,所以无法实现 enterable

✅ 更好的做法:

  • tooltip 原子组件中不做 throttle 以及 enterable 的等交互实现
  • 在 G2 的 tooltip interaction 中去实现 enterable 能力,以及 show 的 throttle 能力

@fangqi5
Copy link
Author

fangqi5 commented Dec 1, 2023

请问这个feature预计在哪个版本发布呢?已经关联好几个版本号了 @pearmini

@hustcc
Copy link
Member

hustcc commented Dec 4, 2023

请问这个feature预计在哪个版本发布呢?已经关联好几个版本号了 @pearmini

我这周一定搞定!!!

@fangqi5
Copy link
Author

fangqi5 commented Dec 11, 2023

Member

🧎🏻跪求这周可以上线,业务方急用~

@cassie-cy
Copy link

Member

🧎🏻跪求这周可以上线,业务方急用~

+1
或者能否暂时提供自己用 interaction 写的替代方案?

@hustcc
Copy link
Member

hustcc commented Dec 12, 2023

@fangqi5 @cassie-cy 已经合并进去了,等待 @pearmini 发版本。不好意思,最近杂事太忙,这个 PR hold 了很久。

@pearmini
Copy link
Member

已经发布了: 5.1.12

@cassie-cy
Copy link

@pearmini @hustcc 线图好像还是不行,见:https://codesandbox.io/s/loving-sound-7y7q9r?file=/index.ts
(打开 type: line 的注释内容)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants