fix: attrs should be deep clone. Closed #288.

antvis · Sep 3, 2018 · 2e4a90b · 2e4a90b
1 parent fa10b9f
commit 2e4a90b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/src/animation/detail.js b/src/animation/detail.js
@@ -13,7 +13,7 @@ const Chart = require('../chart/chart');
 
 let timeline;
 Element.prototype.animate = function() {
-  const attrs = this.get('attrs');
+  const attrs = Util.mix({}, this.get('attrs'));
   return new Animator(this, attrs, timeline);
 };
 

diff --git a/src/animation/group.js b/src/animation/group.js
@@ -10,7 +10,7 @@ const Animator = require('../graphic/animate/animator');
 
 let timeline;
 Shape.prototype.animate = function() {
-  const attrs = this.get('attrs');
+  const attrs = Util.mix({}, this.get('attrs'));
   return new Animator(this, attrs, timeline);
 };
 

diff --git a/test/bug/issue-302-spec.js b/test/bug/issue-302-spec.js
@@ -9,10 +9,6 @@ canvas.height = 260;
 canvas.id = 'issue302';
 document.body.appendChild(canvas);
 
-// function snapEqual(a, b) {
-//   return Math.abs(a - b) < 0.01;
-// }
-
 describe('issue 302', () => {
   it('Issue 302', () => {
     const data = [