Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 数据改变时图例未更新 #1436

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix: 数据改变时图例未更新 #1436

merged 1 commit into from
Apr 8, 2022

Conversation

El-Chiang
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

zengyue
zengyue reviewed Apr 8, 2022
View reviewed changes
packages/f2/src/components/legend/withLegend.tsx
@@ -280,12 +276,6 @@ export default (View) => {
});
}

setItems(items) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥去掉了？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getItems 现在 props 变化时没有更新

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你可以看下我写那个单测，之前的问题是 data 变化时，对应的图例没有更新

@zengyue zengyue merged commit eaeacee into master Apr 8, 2022
@zengyue zengyue deleted the fix/legend-update branch April 8, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyue zengyue zengyue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@El-Chiang @zengyue