fix: guide超出范围不显示 #1944

tangying1027 · 2024-03-21T12:24:55Z

Checklist

npm test passes
tests and/or benchmarks are included
commit message follows commit guidelines

Description of change

github-actions · 2024-03-21T12:31:48Z

	Fails
🚫	`node` failed.

Log

Error:  ReferenceError: Cannot access 'artifact' before initialization
    at dangerfile.js:29:9
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
danger-results://tmp/danger-results-bcda4dbd.json

Generated by 🚫 dangerJS against ea5090e

zengyue · 2024-03-21T13:00:16Z

packages/f2/src/components/guide/views/Arc.tsx

@@ -11,6 +11,8 @@ export interface ArcGuideProps extends GuideProps {
 export default (props: ArcGuideProps) => {
  const { theme = {} } = props;
  const { coord, points, style, animation } = deepMix({ ...theme.line }, props);
+  const checkNaN = points.some((d)=> isNaN(d.x) || isNaN(d.y))


在最后少个分号

tangying1027 requested a review from zengyue March 21, 2024 12:24

zengyue reviewed Mar 21, 2024

View reviewed changes

fix: guide超出范围不显示

ea5090e

tangying1027 force-pushed the fix-guide branch from a945c8c to ea5090e Compare March 21, 2024 13:16

zengyue merged commit b2bee66 into master Mar 22, 2024
8 of 10 checks passed

zengyue deleted the fix-guide branch March 22, 2024 01:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: guide超出范围不显示 #1944

fix: guide超出范围不显示 #1944

tangying1027 commented Mar 21, 2024

github-actions bot commented Mar 21, 2024 •

edited

Loading

zengyue Mar 21, 2024

fix: guide超出范围不显示 #1944

fix: guide超出范围不显示 #1944

Conversation

tangying1027 commented Mar 21, 2024

Checklist

Description of change

github-actions bot commented Mar 21, 2024 • edited Loading

Log

zengyue Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 21, 2024 •

edited

Loading