Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #178 #231

Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix: revert #178 #231

merged 1 commit into from
Oct 25, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Oct 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 根据 测试结果, 在动画和大数据量等需要频繁计算包围盒的场景下,BBox class 相比 BBox object 在性能上会有比较明显的差距。考虑到上层对 BBox class 的需求并不强,对 G 本身也没有明显的收益,因此先改回 BBox object

📝 Changelog

Language Changelog
🇺🇸 English 🗑 [all] Remove export of BBox class. #229
🇨🇳 Chinese 🗑 [全部] 入口文件废弃掉 BBox 类的导出。#229

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 24, 2019

Deploy preview for antv-g ready!

Built with commit e9dea47

https://deploy-preview-231--antv-g.netlify.com

@hustcc
Copy link
Member

hustcc commented Oct 24, 2019

😂无力吐槽

@hustcc hustcc removed their request for review October 24, 2019 11:26
@hustcc hustcc mentioned this pull request Oct 24, 2019
@dxq613 dxq613 merged commit 3850e68 into 4.x Oct 25, 2019
@dxq613 dxq613 deleted the 4.x-without-bbox-class branch October 25, 2019 10:46
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants