New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arrow for lineX, lineY #4905

Merged

hustcc merged 2 commits into v5 from feat-add-arrow-for-lineXY

Apr 23, 2023

Member

hustcc commented Apr 23, 2023 •

edited

Loading

fixed #4845

add arrow for lineX, lineY.
render link use vector.
add screenshot


          feat: add arrow for lineX, lineY

a2cb08d

hustcc requested a review from pearmini

April 23, 2023 03:57

pr-triage bot added the PR: unreviewed label


          chore: update demo, show arrow

4e56cad

hustcc commented

View reviewed changes

__tests__/plots/static/intake-point-annotation.ts Show resolved Hide resolved

hustcc commented

View reviewed changes

__tests__/plots/static/metros-link-trending.ts Show resolved Hide resolved

hustcc commented

View reviewed changes

site/examples/annotation/line/demo/interval-threshold.ts Show resolved Hide resolved

hustcc commented

View reviewed changes

src/shape/lineXY/line.ts Show resolved Hide resolved

hustcc commented

View reviewed changes

src/shape/link/link.ts Show resolved Hide resolved

hustcc commented

View reviewed changes

src/shape/vector/vector.ts Show resolved Hide resolved

hustcc requested review from Aarebecca and pepper-nice

April 23, 2023 04:06

pearmini reviewed

View reviewed changes

Member

pearmini left a comment

这里的箭头支持画在线段的另一端或者两端吗？

Member Author

hustcc commented Apr 23, 2023 •

edited

Loading

这里的箭头支持画在线段的另一端或者两端吗？

这个按照数据驱动来？箭头指向是数据的方向。G 中支持 markerStart 和 markerEnd，但是 G2 只是用了 markerEnd。

Member

pearmini commented Apr 23, 2023

@hustcc 那如果希望上图中的竖着的箭头画在另一边的话该如何声明？

Member Author

hustcc commented Apr 23, 2023

@hustcc 那如果希望上图中的竖着的箭头画在另一边的话该如何声明？

不支持。同样的需求，如果 arrow 想画在线的中间怎么办？这种需要收敛一下。

pearmini approved these changes

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels

hustcc merged commit b5d6595 into v5

hustcc deleted the feat-add-arrow-for-lineXY branch

April 23, 2023 06:27

pr-triage bot added PR: merged and removed PR: partially-approved labels

hustcc added a commit that referenced this pull request


          feat: add arrow for lineX, lineY (#4905)

6038dec

* feat: add arrow for lineX, lineY

* chore: update demo, show arrow

hustcc added a commit that referenced this pull request


          feat: add arrow for lineX, lineY (#4905)

84430a5

* feat: add arrow for lineX, lineY

* chore: update demo, show arrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment