Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(point): opacityAttribute default to colorAttribute #4981

Merged
merged 1 commit into from
May 10, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented May 10, 2023

  • 问题:point mark opacity 通道不生效
  • 出现原因:hollow shape 的默认的 opacity 通道应用于 fillOpacity,所以不生效。目前让 opacityAttribute 默认为 colorAttribute。
export function bodyPointScatterPlotSizeOpacity(): G2Spec {
  return {
    type: 'point',
    data: {
      type: 'fetch',
      value: 'data/body.json',
    },
    encode: {
      x: 'height',
      y: 'weight',
      size: 'weight',
      opacity: 'weight',
    },
  };
}

@pearmini pearmini requested review from Aarebecca and hustcc May 10, 2023 02:15
@pearmini pearmini merged commit 5703414 into v5 May 10, 2023
3 checks passed
@pearmini pearmini deleted the fix/point-opacity branch May 10, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants