Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the transpose color gradient render #5809

Merged
merged 3 commits into from
Nov 17, 2023
Merged

fix: fix the transpose color gradient render #5809

merged 3 commits into from
Nov 17, 2023

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Nov 17, 2023 •
edited

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 修复transpose下折线图和面积图渐变颜色的渲染问题。
  • 在style('gradient', 'y')的情况下，如果设置了transpose，渐变的渲染方向应该是从右往左渲染，对应的角度为180deg；如果是style('gradient', 'x')的情况下，如果设置了transpose，则渲染方向是从上往下渲染，对应的角度为90deg。
    折线图和面积图的颜色渐变需要考虑坐标系 #5361
    1098109031
    1098109031
    877001303
    2313053411

pearmini
pearmini requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优秀，不过还需要在 __tests__/integration/plots/static 下分别针对 line 和 area 各增加一个案例。

@Runtus Runtus changed the title Fix coordinate gradation Fix transpose color gradient render Nov 17, 2023
@Runtus Runtus changed the title Fix transpose color gradient render fix: fix the transpose color gradient render Nov 17, 2023
pearmini
pearmini approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

src/shape/utils.ts Show resolved Hide resolved
@pearmini pearmini linked an issue Nov 17, 2023 that may be closed by this pull request
折线图和面积图的颜色渐变需要考虑坐标系 #5361
Closed
1 task
@pearmini pearmini merged commit 291f0af into antvis:v5 Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

折线图和面积图的颜色渐变需要考虑坐标系
2 participants
@Runtus @pearmini