Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mark): add chord mark #5810

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat(mark): add chord mark #5810

merged 2 commits into from
Nov 20, 2023

Conversation

Gavinchen92
Copy link
Contributor

@Gavinchen92 Gavinchen92 commented Nov 18, 2023 •
edited

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  1. 增加Chord Mark
  2. 增加Chord单测
  3. 增加Chord的配置说明文档

@Gavinchen92
Copy link
Contributor Author

@hustcc @pearmini 帮忙补充下弦图的示例图

pearmini
pearmini requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 site/examples/graph/hierarchy/demo 下面在添加几个 Demo？ Demo 截图你发给我，我帮你上传后，把链接给你

@Gavinchen92
Copy link
Contributor Author

可以在 site/examples/graph/hierarchy/demo 下面在添加几个 Demo？ Demo 截图你发给我，我帮你上传后，把链接给你

放在network下面是否更合适？

@pearmini
Copy link
Member

放在network下面是否更合适？

嗯嗯，放在 network 下面好一点

@pearmini pearmini merged commit 42fdab2 into antvis:v5 Nov 20, 2023
3 checks passed
@pearmini pearmini mentioned this pull request Dec 5, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gavinchen92 @pearmini