Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slider): support sparkline #5832

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat(slider): support sparkline #5832

merged 6 commits into from
Nov 29, 2023

Conversation

deletenothing
Copy link
Contributor

@deletenothing deletenothing commented Nov 22, 2023 •
edited by pearmini

fix: #5668

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

feat(slider): support sparkline
#5668 Slider 支持展示迷你图
slider组件默认使用图表数据展示迷你图
微信截图_20231122160017

pearmini
pearmini requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 运行 npm t 生成一下截图
  • 在官网添加一个例子？

__tests__/plots/static/aapl-line-basic.ts Outdated Show resolved Hide resolved
pearmini
pearmini requested changes Nov 24, 2023
View reviewed changes
src/component/slider.ts Outdated Show resolved Hide resolved
src/component/slider.ts Outdated Show resolved Hide resolved
pearmini
pearmini requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase 一下 V5 的最新分支，不然会包含别的提交记录。

@pearmini
Copy link
Member

@deletenothing 本地运行 npm t 是通过的吗？

@deletenothing
Copy link
Contributor Author

@deletenothing 本地运行 npm t 是通过的吗？

两个failed，就上面截图那两个

@pearmini
Copy link
Member

两个failed，就上面截图那两个

嗯嗯，可以 __tests__/integration/snapshots 中对应的图片删除，然后重新运行 npm t 运行即可

@deletenothing
Copy link
Contributor Author

两个failed，就上面截图那两个

嗯嗯，可以 __tests__/integration/snapshots 中对应的图片删除，然后重新运行 npm t 运行即可

然后我需要再提交一次吗

@pearmini
Copy link
Member

然后我需要再提交一次吗

需要，目的是保证 CI 能通过

pearmini
pearmini approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 过了！非常优秀，还解决了 Windows 下的测试环境问题。

@pearmini pearmini merged commit ab1f0b6 into antvis:v5 Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider 支持展示迷你图
2 participants
@deletenothing @pearmini