Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interaction): reapply some interactions when update #5845

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Nov 27, 2023

存在问题

部分交互 A 触发之后,某些交互 B 需要重新应用才能生效。 比如当 slider 滑动之后,比例尺、图形都发生了变化,element highlight 交互就需要重新应用,才能在新的尺度下对新的图形应用。类似 sliderFilter 的 A 类交互有:

  • brushFilter
  • legendFilter
  • scollbarFilter

需要重新应用的 B 类交互有

  • highlight
  • select
  • event
  • tooltip

解决办法

对于 B 类交互,设置 props:

function A() {
}

A.props = { reapplyWhenUpdate: true }

在执行 A 交互的更新操作的时候,重新应用这些交互

说明

slider 和 scrollbar 相关截图的更新只是元素 id 的变化,图表本身没有变化。

@pearmini pearmini changed the title [WIP] fix(interaction): reapply some interactions when update fix(interaction): reapply some interactions when update Nov 27, 2023
@pearmini pearmini merged commit 54f4098 into v5 Nov 27, 2023
3 checks passed
@pearmini pearmini deleted the fix/interaction-state branch November 27, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants