Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip should account for container in string format #5856

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Nov 28, 2023

任意 Element 可以通过如下方式获取画布,随后获取 DomElement:

element.document.defaultView; // GCanvas
canvas.getContextService().getDomElement(); // <canvas> / <svg>

https://g.antv.antgroup.com/api/builtin-objects/document#defaultview
https://g.antv.antgroup.com/api/canvas/built-in-objects#getcontextservice

目前无法兼容 container 传入字符串(容器 id)的情况,导致 G6 相关示例报错。

@xiaoiver xiaoiver merged commit d923eb9 into v5 Nov 28, 2023
3 checks passed
@xiaoiver xiaoiver deleted the fix-container branch November 28, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants