Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the scaleInY animation(scale in the radial direction) on the polar coordinate #5866

Merged
merged 3 commits into from
Dec 5, 2023
Merged

fix: fix the scaleInY animation(scale in the radial direction) on the polar coordinate #5866

merged 3 commits into from
Dec 5, 2023

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Dec 1, 2023 •
edited by pearmini

close: #4461

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

animation

pearmini
pearmini requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常优秀，只有一个小问题。还可以把效果补充到 PR 描述中。🚀🚀🚀

src/animation/scaleInY.ts Outdated Show resolved Hide resolved
src/animation/scaleInY.ts Outdated Show resolved Hide resolved
@Runtus Runtus changed the title fix: fix the scaleInY animation on the polar coordinate fix: fix the scaleInY animation(scale in the radial direction) on the polar coordinate Dec 4, 2023
pearmini
pearmini approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现的很简洁，解决了你当时没有解决的问题 @hustcc 🤣

@pearmini pearmini merged commit 5422bbb into antvis:v5 Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

动画 scaleInY 在 polar 下不符合预期
2 participants
@Runtus @pearmini