Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tooltip shown on one element line chart. #5917

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: fix tooltip shown on one element line chart. #5917

merged 2 commits into from
Dec 12, 2023

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Dec 11, 2023 •
edited by pearmini

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
image

pearmini
pearmini requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试案例应该放在 __tests__/plots/tooltip 下面，并且生成截图，参考：

G2/__tests__/plots/tooltip/aapl-area-missing-data-transpose.ts

Line 4 in 1a28b3d

export function aaplAreaMissingDataTranspose(): G2Spec {

pearmini
pearmini approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优秀如你，一如既往的高效啊 🤣

@pearmini
Copy link
Member

以后 PR 里面可以添加 fix: #5909 或者 close: #5909 ，就可以关联对应的 issue，并且在合并 PR 的时候自动关闭 issue。

@pearmini pearmini merged commit 52417d3 into antvis:v5 Dec 12, 2023
3 checks passed
@Runtus
Copy link
Contributor Author

Runtus commented Dec 12, 2023

以后 PR 里面可以添加 fix: #5909 或者 close: #5909 ，就可以关联对应的 issue，并且在合并 PR 的时候自动关闭 issue。

哦哦好的，学到了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

折线图单条数据不显示tooltip
2 participants
@Runtus @pearmini