Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): adjust tooltip's position when clipped #6042

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix(slider): adjust tooltip's position when clipped #6042

merged 1 commit into from
Jan 16, 2024

Conversation

pearmini
Copy link
Member

修复当有 slider 的时候，tooltip 不自动调整位置的问题：

问题

  • 原因：有 slider 的时候有 clip path，使用 getBounds 获得容器包围盒有问题
  • 解决办法：用 getRenderBounds 替换

Before

image

After

image

ai-qing-hai
ai-qing-hai approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ai-qing-hai ai-qing-hai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 getRenderBounds 获取盒子信息，

@pearmini pearmini merged commit c6a5ee4 into v5 Jan 16, 2024
3 checks passed
@pearmini pearmini deleted the fix/slider-tooltip branch January 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ai-qing-hai ai-qing-hai ai-qing-hai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pearmini @ai-qing-hai