Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.15: animate: type is undefined does not disable animation #6162

Closed
sspilleman opened this issue Apr 5, 2024 · 4 comments
Closed

5.1.15: animate: type is undefined does not disable animation #6162

sspilleman opened this issue Apr 5, 2024 · 4 comments

Comments

@sspilleman
Copy link

sspilleman commented Apr 5, 2024

Problem

Take a simple barchart

chart
	.interval()
	.animate({ enter: { type: undefined } }) <------------
	.data(data)
	.encode('x', 'genre')
	.encode('y', 'sold');

It still animates. In order to prevent the animation, you also need to add "duration: 0" like so:

chart
	.interval()
	.animate({ enter: { type: undefined, duration: 0 } }) <------------
	.data(data)
	.encode('x', 'genre')
	.encode('y', 'sold');

Which I believe is not correct. I suspect the animation is still enabled, just not visible any longer. It should not be anabled at all

Software
macOS, Chrome

@sspilleman
Copy link
Author

please comment and close if you don't think this is an issue....

@hustcc
Copy link
Member

hustcc commented Apr 10, 2024

If you want to prevent the animation:

.animate(fase);

@sspilleman
Copy link
Author

Thanks, that works! Please add that to the documentation

@hustcc
Copy link
Member

hustcc commented Apr 10, 2024

Thanks, that works! Please add that to the documentation

Would you be interested in submitting a PR (Pull Request)? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants