Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 支持对 geometry 下的 elements zIndex 进行降序 #3173

Merged
merged 3 commits into from Jan 6, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 5, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
  • feat: geometry 增加 sortZIndex 配置项,允许配置 geometry 下的 elements 的展示(zIndex)排序规则
    image

@visiky
Copy link
Member Author

visiky commented Jan 5, 2021

@hustcc @zqlu 你们看下这个配置项合理不,这是当前看到的最方便支持的方法。

但是存在一些 bug,比如交互 reset 后,zIndex 就丢失了,被激活又失去激活态的 element shape 会重置到最底层

image

@visiky visiky requested review from hustcc and lessmost January 5, 2021 03:16
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

😭 Deploy PR Preview fadcdbd failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 5, 2021

Pull Request Test Coverage Report for Build 463654333

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 93.498%

Files with Coverage Reduction New Missed Lines %
src/geometry/base.ts 15 94.73%
Totals Coverage Status
Change from base Build 463413836: 0.06%
Covered Lines: 10709
Relevant Lines: 11107

💛 - Coveralls

src/geometry/base.ts Outdated Show resolved Hide resolved
@hustcc hustcc merged commit 612cf97 into master Jan 6, 2021
@hustcc hustcc deleted the feat-elements-zIndex branch January 6, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants