fix(scrollbar): 修复了由于getYScales方法中去重方法错误导致的 scrollbar会在特定情况下失效(#3569） #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看下这个？#3505 是否也会出现图例不正确的事情 |
|
@visiky 周末还在做Review，辛苦啦，Happy Chinese Valentine's day 🥳 |
hustcc
reviewed
Aug 26, 2021
| const yScale = g.getYScale(); | ||
| const field = yScale.field; | ||
| if (!tmpMap[field]) { | ||
| tmpMap[field] = true; | ||
| return yScale; | ||
| yScales.push(yScale); |
There was a problem hiding this comment.
这个问题的原因是之前 yScales 数组中中可能有 undefined？
There was a problem hiding this comment.
是的，因为之前使用的是map方法去重，但实际上如果map回调函数没有手动return的话，默认会返回undefined
[1,1,2].map(item=>{
if(item!==1){
return item
}
})
// [undefined, undefined, 2]
hustcc
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
修复详情参见🔎
https://www.yuque.com/docs/share/7def9b80-f24c-4d2d-95f9-5a936a49ea5f?# 《G2 Scroball的bug》