fix(backgroundName): 修复 柱形存在背景时添加 interval:click 触发两次的问题 #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview a6341a0 has been successfully built and deployed to https://antvis-G2-preview-pr-3999.surge.sh?type=diff&date=2022-06-28 🕐 Build time: 70.266s
🤖 By Surge Ui Insight |
hustcc
reviewed
Jun 23, 2022
hustcc
approved these changes
Jun 28, 2022
|
为什么加一个 name 就可以解决了？ |
|
@visiky registerShape('interval', 'rect') 内置形状有 Group 和 Shape 。 Shape 直接 name 为 'interval'. 使它 在 'interval:click' 中可以点击到。 而 有背景的时候 返回的是 Group ， 会在后续的代码中 有 Group.name = ['element', Group.name || 'interval' ] 。导致 Group 和 Shape 都有 了 interval 触发会触发它们两个 也就是 点击触发两次 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3748