feat: multi layer 支持配置 annotations & label #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview e21a618 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1913.surge.sh 🕐 Build time: 580.704s
🤖 By surge-preview |
Pull Request Test Coverage Report for Build 362696299
💛 - Coveralls |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
visiky
force-pushed
the
multi-layer/geometry
branch
from
c3c1113
to
e21a618
Compare
hustcc
approved these changes
Nov 14, 2020
jinhuiWong
pushed a commit
to jinhuiWong/G2Plot
that referenced
this pull request
Nov 15, 2020
* refactor(docs): 饼图 & 雷达图 & 瀑布图走查 * feat(multi-layer): 实验室多图层,允许每个图层配置 annotations & 每个图层的每个geometry配置label * fix(geometry-adaptor/label): geometry label 通道与子弹图label通道的适配 * feat(geometry-adaptor/label): label 通道支持透传 fields 映射 * fix(geometry-adaptor): geometry adaptor 的 size 通道怪怪的 * feat(demo): 添加一个动态的多view组合 demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat
labelAPI，label 通道作用于几何对象上；① multi-views 中每个图层的每个geometry需要支持独立配置label；
② 另外plots中的使用 geometry 通道的之后，会再次使用 label 通道，故会直接覆盖，不产生影响；
③ 但后续可以考虑直接使用 geometry 通道来完成 label 通道，以及可以满足 @zqlu 提到的 line plots 的 point 是否支持配置 label
背景
🧪 实验室实践中发现的问题
checklist